Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Issue #70 ran into an issue using a project ID and organization ID with the OpenAI LLM-as-judge provider. In my own testing here, I was not using either env var and simply hadn't supported them. This PR adds support for:
OPENAI_ORG_ID- sent as aOpenAI-OrganizationheaderOPENAI_PROJECT_ID- sent asOpenAI-ProjectheaderThis covers the three auth headers described in the OpenAI Developers Authentication documentation, and matches the OpenAI Python SDK env var naming.
How to test
The PR adds new tests in
judge/client_test.gospecifically for cases where:Checklist
go test -race ./... -count=1)golangci-lint run)